Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid TfToken copy while iterating in usd/primDefinition.cpp #2646

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Sep 5, 2023

Description of Change(s)

The following warning was observed in GCC 11

warning: loop variable ‘srcField’ creates a copy from type ‘const pxrInternal_v0_23__pxrReserved__::TfToken’ [-Wrange-loop-construct]
  523 |     for (const TfToken srcField : defProp.ListMetadataFields()) {
      |                        ^~~~~~~~
note: use reference type to prevent copying
  523 |     for (const TfToken srcField : defProp.ListMetadataFields()) {
      |                        ^~~~~~~~
      |                        &

Making srcField a reference type avoids the copy of the TfToken.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8652

@pixar-oss pixar-oss merged commit 9ed3c50 into PixarAnimationStudios:dev Sep 19, 2023
34 of 36 checks passed
@nvmkuruc nvmkuruc deleted the usdloopwarning branch December 29, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants