Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TF_PP_TUPLE_ELEM using tf/preprocessorUtilsLite.h #2652

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Sep 5, 2023

Description of Change(s)

BOOST_PP_TUPLE_ELEM can be replaced with a combination of TF_PP_EAT_PARENS and TF_PP_VARIADIC_ELEM from tf/preprocessorUtilsLite.h. This replacement macro has been packaged as TF_PP_TUPLE_ELEM and all usage of the boost macro has been removed. The replacement macro no longer supports the size parameter, but the boost documentation suggests this parameter has been deprecated and is unused.

Test cases have been added to tf/testenv/preprocessorUtils.cpp for TF_PP_TUPLE_ELEM. The behavior matches the size-less version of BOOST_PP_TUPLE_ELEM for the provided test cases.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8658

@pixar-oss pixar-oss merged commit 6f86e55 into PixarAnimationStudios:dev Oct 2, 2023
3 of 5 checks passed
@nvmkuruc nvmkuruc deleted the tfpptuple branch December 29, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants