Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneAPI TBB selector for 2019/2021 adapted from brechtvl #2694

Closed
wants to merge 1 commit into from

Conversation

aaye
Copy link

@aaye aaye commented Sep 14, 2023

Description of Change(s)

  • Originally filed under USD-6600, Issue [tbb] Please support tbb version 2021.1.1  #1471
  • Looked like brechtvl did not continue to see their change through the pipeline. Took and adapted the change to fix compilation, pathing, and build associated issues.
  • Successfully compiled with both 2019 and 2021

Fixes Issue(s)

  • Facilitates updating to more recent releases for OneAPI TBB
  • I have verified that all unit tests pass with the proposed changes
  • [x ] I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8708

@loqs
Copy link

loqs commented Sep 29, 2023

Is this intended to replace #2457 #2458 #2459 #2460 #2461 #2462 #2463 #2464 #2465 and #2466?

@spiffmon
Copy link
Member

Thanks for asking that, @loqs , as:

  1. We have @brechtvl 's PR's queued up to process shortly
  2. We specifically asked him to break the changes up as he did for fine-grained testing and regression analysis, and we would still not want to accept a monolithic change.

@aaye , can you please confirm, and let us know if you can follow the pattern of the previous PR's, and also let us know the scale of the fixes you made on top of the earlier work?

@brechtvl
Copy link
Contributor

From what I can tell the main addition here is build system fixes for Windows? I did not test my changes on Windows, so getting that to work would be great. I can add additional changes to my PRs if needed (might be just #2466).

@spiffmon
Copy link
Member

spiffmon commented Apr 8, 2024

Closing this as we are finishing up work to incorporate @brechtvl 's PR's.

@spiffmon spiffmon closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants