Replace boost::variant
with std::variant
in sdf
#2718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This replaces
boost::variant
withstd::variant
insdf
. The API usesboost::bad_get
to communicate a failure to parse due to a bad variant access or an out of range error. This change remaps the STLstd::bad_variant_access
to aboost::bad_get
to preserve this behavior. As visitors used viastd::visit
do not specifyresult_type
, the return type for several helper methods has been converted toauto
.One or more follow up changes will be needed to remove a spurious include of
boost/variant.hpp
from the parser logic and replaceboost::bad_get
with a new proposedSdf_BadGet
exception.Fixes Issue(s)