Fix timeVaryingBits for lights, light filters, and cameras for timesampled transform attribute #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-8833 |
|
The failure seems to be a timeout and likely unrelated - how do I rerun the checks? |
…ctedByAttrNamed Transforms would not be excluded from variability correctly for lights, light filters, and cameras due to using the base name instead of the full attribute name in the function UsdGeomXformable::IsTransformationAffectedByAttrNamed which relies on the attribute's namespace to detect transformation attributes.
sdawson-nvidia
force-pushed
the
dev_fix_timevarying_dirty_params
branch
from
41adfa7
to
fc0e62f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Change calls to
UsdGeomXformable::IsTransformationAffectedByAttrNamedto useGetNameinstead ofGetBaseNameso the namespace can be checked against.Fixes Issue(s)
Tested on Windows, these tests fail:
The following tests FAILED:
430 - testUsdZipFile (Failed)
678 - testUsdviewNavigationKeys (Failed)
694 - testUsdResolverExample (Failed)
Errors while running CTest
Based on other issues, these seem to be failing for a while, on windows. testUsdZipFile fails as an example due to windows line endings vs unix line endings in the write portion of the test (crc doesn't match the expected value).