-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Python 3.11 builds with Boost 1.82 #2742
Conversation
Filed as internal issue #USD-8843 |
@dgovil Hey Dhruv, I'm looking at merging this in but I'm running into issues building OpenImageIO on my Linux machine with this change. I get a bunch of undefined reference errors with boost::filesystem, like below. Do you see anything similar on your machine?
|
Oh interesting. I must have built without OIIO. I'll check that out today and get back to you |
1f109b2
to
c255cf0
Compare
Still looking for OIIO, but I was hitting an issue when I updated my Toolchain and Boost's fallback to C++03 was using deprecated symbols. I've set Boost to Cxx17 on macOS, though I think at some point we should do that across the board? I don't have a Win/Linux build setup to test if they also need 17 or not. |
@sunyab , at least on macOS with Clang 15, I'm not getting a compile error with OIIO. I did have to make a change to Boost for macOS to use C++17 and I wonder if adding those cxxflags to Linux as well would fix things for you? |
I was able to get past my issue by updating my version of CMake to latest. I was running 3.25.3 which didn't have explicit support for boost 1.82. So what I'd propose is:
If you'd like, I'd be happy to take this off your plate and make these changes locally since I'm already in the middle of testing builds anyway. What do you think? |
Ah interesting. Yeah, if you're already in there, it's probably faster if you do it since I won't be able to adequately test Linux. Thank you! Split out the CXX17 PR here #2868 |
c255cf0
to
71725ca
Compare
I've checked in an updated version of this PR internally and it'll go out with the next updates to the dev branch. Closing this out, thanks! |
Thanks, Sunya! |
Description of Change(s)
This PR resolves #2741 by using Boost 1.82 for Python 3.11 or above, in accordance with VFX Platform CY2024.
Fixes Issue(s)
#2741