Use macOS linkage style for frameworks and system libs #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ACE_LINK_LIBRARIES doesn't hardcode SDK versions
meshula
reviewed
Nov 1, 2023
meshula
reviewed
Nov 1, 2023
meshula
reviewed
Nov 1, 2023
|
I see you figured out how to specify frameworks in a non-full-path-name way :) |
|
Updated with your notes |
|
Filed as internal issue #USD-8896 |
2 tasks
2 tasks
pixar-oss
merged commit e4248cb
into
PixarAnimationStudios:release
3 of 5 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Change macOS platform linkage to not use find_library, so that INTERFACE_LINK_LIBRARIES doesn't hardcode SDK versions
Fixes Issue(s)
#2771