Specify invalid UTF-8 characters in URI scheme registration errors #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-9070 |
nvmkuruc
force-pushed
the
arutf
branch
2 times, most recently
from
925525c
to
6102764
Compare
nvmkuruc
force-pushed
the
arutf
branch
3 times, most recently
from
08c796a
to
4d18d2d
Compare
2 tasks
nvmkuruc
force-pushed
the
arutf
branch
2 times, most recently
from
8524027
to
9f7fa35
Compare
sunyab
added
the
usd-utf8-identifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
(Depends on #2858 and #2889)
#2814 observed that a stray
-from adiffended up in the error reporting code for scheme validation. The conditional partitioning ASCII and UTF-8 code paths does not work, and the broken ASCII code path appears to never be exercised.Now that #2858 has provided a class for encoding code points into strings, the same code path can be used for both.
Fixes Issue(s)