Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for skipARKitRootLayerCheck warning #2875

Merged

Conversation

dgovil
Copy link
Collaborator

@dgovil dgovil commented Dec 18, 2023

Description of Change(s)

I forgot to remove the not in the check when providing the deprecation warning.
#2863

This fixes it so it only warns when the flag is actually supplied as True, since the default is False and would have always triggered.

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Oops sorry I missed that during review, will get this in right now. Thanks @dgovil for a quick fix.

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-9101

@pixar-oss pixar-oss merged commit 1149e34 into PixarAnimationStudios:dev Jan 6, 2024
5 checks passed
@dgovil dgovil deleted the fix-skipARKitRootLayerCheck branch January 6, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants