Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo inlining of TfIsUtf8CodePointXid{Start,Continue} #2883

Merged
merged 3 commits into from
Jan 6, 2024

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Dec 20, 2023

Description of Change(s)

#2857 was focused on reducing the cost / instruction count of initializing the range tables for the Xid character classes. It also inlined their usage in unicodeUtils.{h,cpp}. However, unicodeCharacterClasses is private and cannot be included in the header for unicodeUtils to be used outside of Tf.

This rolls back just that part of #2857.

It also removes the dependency on the TF_MAX_CODE_POINT symbol inherited from unicodeCharacterClasses to avoid including the private header in the test case.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-9114

Copy link

@dsyu-pixar dsyu-pixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore -- my review comment (for PR 2888) was accidentally copied here as well.

@pixar-oss pixar-oss merged commit d48c939 into PixarAnimationStudios:dev Jan 6, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants