Undo inlining of TfIsUtf8CodePointXid{Start,Continue}
#2883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
#2857 was focused on reducing the cost / instruction count of initializing the range tables for the
Xid
character classes. It also inlined their usage inunicodeUtils.{h,cpp}
. However,unicodeCharacterClasses
is private and cannot be included in the header forunicodeUtils
to be used outside ofTf
.This rolls back just that part of #2857.
It also removes the dependency on the
TF_MAX_CODE_POINT
symbol inherited fromunicodeCharacterClasses
to avoid including the private header in the test case.Fixes Issue(s)