Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nullptr check for _FindEntry (like _InsertEntry and related) #2905

Merged

Conversation

marcodiiga
Copy link
Contributor

Description of Change(s)

Added nullptr check for _FindEntry (_InsertEntry and others all assume that the operation might fail, makes sense to include the _FindEntry as well). This can also happen (albeit erroneously and unsupportedly) in multithreaded situations and possibly in resource constrained conditions.

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-9152

@asluk
Copy link
Collaborator

asluk commented Jan 26, 2024

@jesschimein this would be a good one to get in for v24.03 -- let me know if the USD team at Pixar have any particular concerns-- ideally there would have been a unit test case as well, but we weren't able to quite nail down a repro. In any case it's good to guard against crashes here, and I don't think there is any downside to this. Happy to talk through it more though. Thanks!

@pixar-oss
Copy link
Member

Thanks for flagging! We're looking at it internally for inclusion for 24.03!

@pixar-oss pixar-oss merged commit 389c1b6 into PixarAnimationStudios:dev Feb 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants