Change value type of TfUtf8CodePointIterator
to TfUtf8CodePoint
#2906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
TfUtf8CodePointIterator
was originally written before theTfUtf8CodePoint
class was introduced. This change makes the value and reference type of the iterator aTfUtf8CodePoint
directly instead of expecting clients to construct it themselves.It also introduces a
TfUtf8CodePointFromAscii
helper function to make it easier to create code points from known ASCII characters.This change also simplifies several test cases and usages. For example,
_IsValidIdentifier
no longer has to branch.Currently, both the iterator and the code point class employ validation to ensure that code points outside the unicode range or surrogate code points are not decoded. It may be desirable to avoid this redundancy so that the validation is delegated entirely to the code point class in a future change.
Fixes Issue(s)