make PXR_VERSION a valid / comparable c/c++ integer #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, PXR_VERSION is defined as "0197" - which isn't even a valid c/c++ integer literal, as the '0' will cause it to be interpreted as an octal value, but '9' isn't an octal digit. Even if it didn't have the leading 0, however, it still wouldn't be useful for comparing numerically, because we would have, ie, 19.07 < 18.11: 197 < 1811
|
Filed as internal issue #USD-5390 |
|
Great sug, thanks @elrond79 -- don't worry about the merge conflict, we'll take care of it. |
pixar-oss
added a commit
that referenced
this pull request
Jul 17, 2019
make PXR_VERSION a valid / comparable c/c++ integer (Internal change: 1987050)
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
…lve/dev Revert "OGSMOD-4774 : Sync USD develop branch to newest public USD - Q1S4 (PixarAnimationStudios#875)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
currently, PXR_VERSION is defined as "0197" - which isn't even a valid
c/c++ integer literal, as the '0' will cause it to be interpreted as an
octal value, but '9' isn't an octal digit. Even if it didn't have the
leading 0, however, it still wouldn't be useful for comparing numerically,
because we would have, ie, 19.07 < 18.11:
197 < 1811
Fixes Issue(s)