Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] checkNewVersion Blocks dev and build Commands #1081

Closed
3 tasks done
cheezone opened this issue Sep 19, 2024 · 1 comment
Closed
3 tasks done

[BUG] checkNewVersion Blocks dev and build Commands #1081

cheezone opened this issue Sep 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@cheezone
Copy link
Contributor

What happened?

Issue:
The checkNewVersion function is using await, which blocks the dev and build commands. As a result, both commands are delayed until checkNewVersion finishes executing. This adds unnecessary wait time before starting these processes.

Proposed Solution:
Consider making checkNewVersion non-blocking. One possible approach is to trigger checkNewVersion asynchronously without await, allowing the dev and build commands to run in parallel. The version check could happen in the background and optionally log results when finished, without affecting the command startup time.

If you still want to notify the user about a new version, logging could happen after the command starts, without delaying the process execution.

Version

Latest

What OS are you seeing the problem on?

No response

What browsers are you seeing the problem on?

No response

Relevant log output

No response

(OPTIONAL) Contribution

  • I would like to fix this BUG via a PR

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@cheezone
Copy link
Contributor Author

#1082 Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant