Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] build --tag=staging #196

Closed
3 tasks done
louisgv opened this issue Sep 9, 2022 · 3 comments · Fixed by #282
Closed
3 tasks done

[RFC] build --tag=staging #196

louisgv opened this issue Sep 9, 2022 · 3 comments · Fixed by #282
Assignees
@louisgv
Labels
enhancement New feature or request

Comments

@louisgv
Copy link
Contributor

louisgv commented Sep 9, 2022

How do you envision this feature/change to look/work like?

--staging="staging-tag" or by default it's just "staging"

What is the purpose of this change/feature? Why?

For cases where developers makes more deployment than just prod (staging, alpha, beta)

(OPTIONAL) Example implementations

No response

(OPTIONAL) Contact Details

No response

Verify canary release

  • I verified that the issue exists in plasmo canary release

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@louisgv louisgv added the enhancement New feature or request label Sep 9, 2022
@louisgv louisgv changed the title [RFC] Staging or more deployment environment [RFC] Staging or more deployment tag Oct 4, 2022
@louisgv louisgv changed the title [RFC] Staging or more deployment tag [RFC] Staging or more build tag Oct 4, 2022
@louisgv
Copy link
Contributor Author

louisgv commented Oct 4, 2022

Also the ability to build the development package would be nice

@louisgv
Copy link
Contributor Author

louisgv commented Oct 4, 2022 •
edited
Loading

Tagged build should:

  • Use process.env.NODE_ENV === "production"
  • Bundle sends to chrome-mv3-{tag}
  • Has staging specific: Icons + Name + Env file

@louisgv louisgv changed the title [RFC] Staging or more build tag [RFC] Staging or more build --tag Oct 4, 2022
@louisgv louisgv changed the title [RFC] Staging or more build --tag [RFC] build --tag=staging Oct 4, 2022
@louisgv louisgv mentioned this issue Oct 4, 2022
Closed
3 tasks
@louisgv louisgv self-assigned this Oct 8, 2022
@louisgv louisgv pinned this issue Oct 8, 2022
@louisgv louisgv unpinned this issue Oct 8, 2022
@imbdb
Copy link
Contributor

imbdb commented Oct 25, 2022

@louisgv
I feel that --tag will be more useful if we allow for both development and production.

regarding the tagged env file
we can have a order like this

  1. .env.{tag}
  2. .env.{NODE_ENV}.{tag}
  3. .env.{NODE_ENV}
  4. .env.{NODE_ENV}.local
  5. .env.local

We can have the same order for icons

@louisgv louisgv pinned this issue Oct 30, 2022
@louisgv louisgv mentioned this issue Nov 5, 2022
Merged
4 tasks
louisgv added a commit that referenced this issue Nov 5, 2022
@imbdb @louisgv
feat: --tag parameter #196 (#282)
f4ed50f 
* --tag implementation

* revert utils

* use app-specific flag map

* remove unused import

Co-authored-by: Louis <[email protected]>
@louisgv louisgv unpinned this issue Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louisgv louisgv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: --tag parameter #196 imbdb/plasmo
2 participants
@imbdb @louisgv