-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Auto-reload content-script needs to check context #215
Comments
Wow this is much more annoying than I thought - if you have a content script, the reload screw up everything! |
I found this issue too but on |
@chenka yup it's super annoying. I will prioritize fixing it this week, otherwise, it sucks to work on my own extension xD... |
Also with this fix, we will adding back react-refresh runtime as well which will provide HMR for static pages |
Hmm... the background sw is propagating thorough every pages, causing the socket hmr to double trigger... will need to figure out a way to determine if bgsw is running under the context of entry pages. |
We might need to disable bgsw socket, and only reserves the HMR reload to the pages and scripts. |
Discussed in #206
Originally posted by xmsz September 14, 2022
Expect:
reload options.html
Actully:
options.html close itself due to reload plugin
The text was updated successfully, but these errors were encountered: