Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Live reload doesn't work when new entries are added #241

Closed
2 tasks done
callmekatootie opened this issue Sep 30, 2022 · 2 comments · Fixed by #255
Closed
2 tasks done

[BUG] Live reload doesn't work when new entries are added #241

callmekatootie opened this issue Sep 30, 2022 · 2 comments · Fixed by #255
Labels
bug Something isn't working

Comments

@callmekatootie
Copy link

What happened?

I tried out the with-content-script and with-newtab examples.

I created new files (content.ts and newtab.tsx correspondingly) and in each case, the effect didn't display even after waiting couple more seconds. I had to visit chrome://extensions page and manually reload the extension.

Not sure if this is expected (since new files were added). The live reload works when I update existing files

Version

Latest

What OS are you seeing the problem on?

Linux

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

(OPTIONAL) Contact Details

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@callmekatootie callmekatootie added the bug Something isn't working label Sep 30, 2022
@callmekatootie
Copy link
Author

callmekatootie commented Sep 30, 2022

Forgot to mention that I had executed npm run dev before I tried to add the new files (and the command was still active / running) - development server was very much active - and yet I face the issue

@louisgv louisgv changed the title [BUG] Live reload doesn't work when new extension pages are added [BUG] Live reload doesn't work when new entries are added Sep 30, 2022
@louisgv
Copy link
Contributor

louisgv commented Sep 30, 2022

I think this is the case when we just have a popup and don't reload accordingly. I will note this as another edge case for #215

@louisgv louisgv mentioned this issue Oct 8, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants