Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Automatically resolve system node browser polyfill #271

Closed
3 tasks done
louisgv opened this issue Oct 23, 2022 · 0 comments · Fixed by #300
Closed
3 tasks done

[RFC] Automatically resolve system node browser polyfill #271

louisgv opened this issue Oct 23, 2022 · 0 comments · Fixed by #300
Assignees
@louisgv
Labels
enhancement New feature or request

Comments

@louisgv
Copy link
Contributor

louisgv commented Oct 23, 2022

How do you envision this feature/change to look/work like?

When developer consumes a library such as grpc, which relies on the bundler to supply missing browser polyfill such as os, http2

Plasmo should polyfill these modules automatically without user having to manually install/debug with them (similar behavior to nextjs)

What is the purpose of this change/feature? Why?

Manually installing these polyfills is a PITA, and folks rather see just their direct dependency, and not the polyfilled.

One drawback to this tho, is that now Plasmo essentially "relies" on the 3rd party polyfills - although they are open-source, there are cases where developer might want to provide their own polyfill. This feature must ensure that the developer's dependency is respected before providing its opinionated polyfill.

(OPTIONAL) Example implementations

No response

(OPTIONAL) Contact Details

No response

Verify canary release

  • I verified that the issue exists in plasmo canary release

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@louisgv louisgv added the enhancement New feature or request label Oct 23, 2022
@louisgv louisgv pinned this issue Oct 23, 2022
@louisgv louisgv self-assigned this Oct 23, 2022
@louisgv louisgv unpinned this issue Oct 23, 2022
@louisgv louisgv pinned this issue Oct 30, 2022
@louisgv louisgv linked a pull request Nov 20, 2022 that will close this issue
chore: bump deps #300
Merged
2 tasks
@louisgv louisgv unpinned this issue Nov 20, 2022
louisgv added a commit that referenced this issue Nov 21, 2022
@louisgv
chore: bump deps, fix #297, fix #291, fix #271 (#300)
7ba2f2a 
* chore: bump deps, minor version

* bump canary version

* fix #297, revamp all utils import and env parsing pipeline

* update prettier plugin target

* feat 271: built-in polyfill
@louisgv louisgv mentioned this issue Dec 17, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louisgv louisgv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump deps PlasmoHQ/plasmo
1 participant
@louisgv