Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Side panel API #615

Closed
3 of 4 tasks
xeroxcsn opened this issue Jun 6, 2023 · 12 comments · Fixed by #651
Closed
3 of 4 tasks

[RFC] Side panel API #615

xeroxcsn opened this issue Jun 6, 2023 · 12 comments · Fixed by #651
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@xeroxcsn
Copy link

xeroxcsn commented Jun 6, 2023

How do you envision this feature/change to look/work like?

Thank you for the work! I wanted to create an extension on the new released Chrome side panel, and I am wondering if that can be done with Plasmo.

https://developer.chrome.com/docs/extensions/reference/sidePanel/#overview

What is the purpose of this change/feature? Why?

Basically I want to build an extension for my tabs management, but I will navigate to different tabs often. I want the extension can be kept in the side panel of chrome.

(OPTIONAL) Example implementations

Would it be like the popup layout and we can use it just like creating a sidePanel.tsx, and add manifest override in package.json like this:
permissions: ["sidePanel"]

(OPTIONAL) Contribution

  • I would like to contribute to this RFC via a PR

Verify canary release

  • I verified that the issue exists in plasmo canary release

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@xeroxcsn xeroxcsn added the enhancement New feature or request label Jun 6, 2023
@louisgv
Copy link
Contributor

louisgv commented Jun 7, 2023

I think this feature will be like sandbox - simply add a sidepanel.tsx and you're good to go, no need to add permission manually.

@xeroxcsn
Copy link
Author

xeroxcsn commented Jun 7, 2023

Thanks for the reply!
May I know that is this planned to work on?

@louisgv
Copy link
Contributor

louisgv commented Jun 7, 2023

It's open for contribution if you would like to get it done :) @xeroxcsn

@louisgv louisgv added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 7, 2023
@xeroxcsn
Copy link
Author

xeroxcsn commented Jun 7, 2023

Got it!
I will try to contribute after I understand how it is working :)

@louisgv louisgv pinned this issue Jun 13, 2023
@louisgv louisgv self-assigned this Jun 13, 2023
@gotjoshua
Copy link

@louisgv are you starting the implementation?

Just checking cuz the issue is still called RFC...

@louisgv
Copy link
Contributor

louisgv commented Jun 15, 2023

@gotjoshua ah just prioritizing it, what's on your mind?

@louisgv
Copy link
Contributor

louisgv commented Jun 15, 2023

LMK if you wanna spearhead it as well or if you're already cooking something for this feat @gotjoshua

@gotjoshua
Copy link

basically just looking forward to it! and if you have design decisions to make, i am happy to think along. no extra bandwidth for hacking along at the moment.
cheers...

@ddosakura
Copy link

In the current version, you can use the sidePanel through the following way:

{
  "manifest": {
    "permissions": [
      "sidePanel"
    ],
    "side_panel": {
      "default_path": "tabs/sidepanel.html"
    }
  }
}
// tabs/sidepanel.tsx

function IndexSidePanel() {
  // ...
}

export default IndexSidePanel;

@xeroxcsn
Copy link
Author

In the current version, you can use the sidePanel through the following way:

thank you! it works!

@louisgv louisgv linked a pull request Jun 29, 2023 that will close this issue
3 tasks
@louisgv louisgv changed the title [RFC] Side panel on Chrome [RFC] Side panel API Jun 29, 2023
@louisgv louisgv unpinned this issue Jul 11, 2023
@duoluodexiaoxiaoyuan
Copy link

In the current version, you can use the sidePanel through the following way:

{
  "manifest": {
    "permissions": [
      "sidePanel"
    ],
    "side_panel": {
      "default_path": "tabs/sidepanel.html"
    }
  }
}
// tabs/sidepanel.tsx

function IndexSidePanel() {
  // ...
}

export default IndexSidePanel;

你好,我看了文档说建一个sidepanel.tsx就会跳转,我现在是要实现点击按钮实现跳转
image
image

 "side_panel": {
>       "default_path": "tabs/sidepanel.html"
>     }

配置上面的是默认又用html吗

@duoluodexiaoxiaoyuan
Copy link

I want to achieve opening the sidebar by clicking a button, but now whenever the icon is clicked, the sidebar opens and the popup.html page does not pop up. How can this issue be resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants