feat: sidepanel API #651
Merged
feat: sidepanel API #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
2 tasks
|
@louisgv When will this feature be improved and merged? |
|
@xudaolong Can you review and test it out on your end? |
* Support nested directories in contents dir * Refactor index filter logic into addDirectory * Rename to addContentScriptsIndexFiles * added a simple exampel to test * add a check for cs --------- Co-authored-by: L❤️ ☮️ ✋ <[email protected]>
|
@louisgv I tested it and there is nothing wrong with it, including the messages, awesome! |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR aligns the sidepanel API on chrome and the sidebar_action API on firefox
Code of Conduct
Contacts
If your PR is accepted, we will award you with the
Contributorrole on Discord server.To join the server, visit: https://www.plasmo.com/s/d