Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improved bugfix for CSP Restriction for TrustedTypePolicy Creation in Loading Indicator #1000

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

agungjk
Copy link
Contributor

@agungjk agungjk commented Jun 13, 2024

…on in Loading Indicator

Details

This PR aims to fix the issue #985
The previous issue is exist on website like linkedin.com, I try to fix it

Code of Conduct

  • [ √] I agree to follow this project's Code of Conduct
  • [√ ] I agree to license this contribution under the MIT LICENSE
  • [ √] I checked the current PR for duplication.

Contacts

  • (OPTIONAL) Discord ID:

If your PR is accepted, we will award you with the Contributor role on Discord server.

To join the server, visit: https://www.plasmo.com/s/d

@agungjk
Copy link
Contributor Author

agungjk commented Jun 13, 2024

i create a hotfix for this issue on this PR #1000
you can test or use my bugfix

  1. clone the repo
    git clone [email protected]:agungjk/plasmo.git --recurse-submodules

  2. install dependency
    pnpm install

  3. build the repo
    pnpm run build:cli

  4. go to the folder cd cli/plasmo and link the runtime pnpm link --global

  5. you can test it by running plasmo dev instead of pnpm run dev on your plasma project

@louisgv louisgv changed the title ix: Improved bugfix for CSP Restriction for TrustedTypePolicy Creation in Loading Indicator fix: Improved bugfix for CSP Restriction for TrustedTypePolicy Creation in Loading Indicator Jun 13, 2024
Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@louisgv louisgv merged commit c5dc1a6 into PlasmoHQ:main Jun 13, 2024
1 check passed
@eldiegod
Copy link

eldiegod commented Jun 17, 2024

Has this been released? I'm still having trouble with Linkedin

Nvm, it is, thanks a lot guys 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants