Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log the target when running plasmo build or plasmo dev #1053

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

timrogers
Copy link
Contributor

@timrogers timrogers commented Aug 23, 2024

Details

This logs the --target when running plasmo build or plasmo dev, making it easy to see at a glance what browser target you are building for.

This can help to avoid surprises and confusion if the thing you think is getting built isn't getting built!

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I agree to license this contribution under the MIT LICENSE
  • I checked the current PR for duplication.

Contacts

  • (OPTIONAL) Discord ID:

If your PR is accepted, we will award you with the Contributor role on Discord server.

To join the server, visit: https://www.plasmo.com/s/d

This logs the `--target` when running `plasmo build` or `plasmo
dev`, making it easy to see at a glance what browser target you
are building for.

This can help to avoid surprises and confusion if the thing you
think is getting built isn't getting built!
Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@louisgv louisgv added this pull request to the merge queue Aug 26, 2024
Merged via the queue into PlasmoHQ:main with commit 05a3a77 Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants