Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add PLASMO_BUILD_PATH and --build-path #243

Merged
merged 7 commits into from
Oct 5, 2022
Merged

feat: add PLASMO_BUILD_PATH and --build-path #243

merged 7 commits into from
Oct 5, 2022

Conversation

louisgv
Copy link
Contributor

@louisgv louisgv commented Sep 30, 2022 •
edited
Loading

Details

  • closes #
  • If RFC, it has been approved for implementation.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current PR for duplication.

@louisgv
Copy link
Contributor Author

louisgv commented Oct 4, 2022

Mainly stop-gap until #162

@louisgv louisgv marked this pull request as ready for review October 4, 2022 01:09
@louisgv louisgv requested a review from ColdSauce October 4, 2022 01:09
@louisgv louisgv changed the title feat: flag build-dir feat: add PLASMO_BUILD_PATH and --build-path Oct 4, 2022
@ColdSauce
Copy link
Contributor

It doesn't look like there's a PLASMO_BUILD_PATH env variable support here that the PR mentions. Am I not looking in the right place?

@louisgv louisgv requested a review from ColdSauce October 5, 2022 01:13
@louisgv
Copy link
Contributor Author

louisgv commented Oct 5, 2022

It doesn't look like there's a PLASMO_BUILD_PATH env variable support here that the PR mentions. Am I not looking in the right place?

I think you reviewed some old change before I pushed xD... Basically yesterday I changed the PR title then worked on it, then didn't push xd..

@louisgv
Copy link
Contributor Author

louisgv commented Oct 5, 2022

More context on some of the change here: https://discord.com/channels/946290204443025438/1024646012083642471/1027012116533755914

@louisgv louisgv merged commit fbfe52e into main Oct 5, 2022
@louisgv louisgv deleted the feat-flag-build-dir branch October 5, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColdSauce ColdSauce ColdSauce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Plasmo Open Docs Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louisgv @ColdSauce