feat: CSUI multiple inline and overlay anchors #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisgv
changed the title
ColdSauce
approved these changes
Oct 17, 2022
Co-authored-by: Stefan Aleksic <[email protected]> Signed-off-by: L <[email protected]>
…com:PlasmoHQ/plasmo into 198-rfc-csui-mounting-into-multiple-element
viclai
reviewed
Nov 28, 2022
| ) => Async<ShadowRoot> | ||
|
|
||
| export type PlasmoRender = ( | ||
| props: { | ||
| createRootContainer?: (p: PlasmoCSUIAnchor) => Async<Element> |
There was a problem hiding this comment.
Does the first parameter need to be required? I was wondering how we'd use this if we're not mounting into multiple elements, like in the following example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Code of Conduct