Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supports js extension for react and vanilla ui #363

Merged
merged 6 commits into from
Dec 30, 2022
Merged

feat: supports js extension for react and vanilla ui #363

merged 6 commits into from
Dec 30, 2022

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Dec 29, 2022

closes #356

Details

Code of Conduct

@louisgv louisgv self-requested a review December 29, 2022 18:28
@louisgv
Copy link
Contributor

louisgv commented Dec 30, 2022

Note that this PR breaks CSUI.

ATM, Plasmo uses the .tsx vs .ts extensions to differentiate CSUI vs CS (plain content script with no extra UI mount runtime).

We can incorporate .jsx extension for this PR, which helps differentiate between code that has React vs plain JS without JSX (for Flow)

@pd4d10 For rescript - you can create a rescript parcel transformer, that incorporates the .res file extension. We can incorporate it in our config and that will allow you to use the .res extension for rescript with zero external bundlings needed.

@louisgv
Copy link
Contributor

louisgv commented Dec 30, 2022

Move the above to #367

louisgv
louisgv approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seasoned and ready to go 👨‍🍳

@louisgv louisgv mentioned this pull request Dec 30, 2022
Closed
3 tasks
@louisgv louisgv merged commit b6b8aea into PlasmoHQ:main Dec 30, 2022
@pd4d10 pd4d10 deleted the patch-1 branch December 30, 2022 02:56
This was referenced Dec 30, 2022
Merged
Open
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisgv louisgv louisgv approved these changes

Assignees

@louisgv louisgv

@pd4d10 pd4d10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Supports jsx file extensions
2 participants
@pd4d10 @louisgv