Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Vue throwing warning in console because __VUE_OPTIONS_API__ and __VUE_PROD_DEVTOOLS__ are not definede #699

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

sincspecv
Copy link
Contributor

Details

Vue is ouputting the following error in console:

__VUE_OPTIONS_API__, __VUE_PROD_DEVTOOLS__ are not explicitly defined. You are running the esm-bundler build of Vue, which expects these compile-time feature flags to be globally injected via the bundler config in order to get better tree-shaking in the production bundle.

For more details, see https://link.vuejs.org/feature-flags.

This is fixable by assigning a boolean value to each of these global variables but it needs to be done before createApp() is called. There is no configuration option in Parcel to handle this so I assigned values to these variables in the Vue3 static template file (cli/plasmo/templates/static/vue3/index.ts).

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I agree to license this contribution under the MIT LICENSE
  • I checked the current PR for duplication.

Contacts

  • (OPTIONAL) Discord ID: dino_morrison

If your PR is accepted, we will award you with the Contributor role on Discord server.

To join the server, visit: https://www.plasmo.com/s/d

@louisgv
Copy link
Contributor

louisgv commented Jul 23, 2023

@sincspecv Thanks for the PR! I will review and cut a release likely Wednesday. LGTM otherwise!

@louisgv louisgv merged commit 6c57cab into PlasmoHQ:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants