Switch inject-socket to use getSocketHostname #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadhirvelm
commented
Sep 8, 2023
| @@ -59,6 +59,14 @@ export function getHostname() { | |||
| return runtimeData.host | |||
| } | |||
|
|
|||
| export function getSocketHostname() { | |||
| if (!runtimeData.host || runtimeData.host === "0.0.0.0") { | |||
| return "localhost"; | |||
There was a problem hiding this comment.
It's probably worth mentioning that attempting to connect to 0.0.0.0 from a content script UI results in this error:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In two previous PRs, support for changing the HMR host and serve host were added:
#745
fa6045e
Unfortunately, the HMR was still not working when binding to 0.0.0.0. After some exploration, one culprit is that the content script UI isn't successfully connecting to the HMR server. The function it was using to get the hostname of the HMR server would return the location's hostname where the content script was opened on. This PR adds a new function that ensures when fetching the hostname for a socket, it returns "localhost" by default instead of the location's hostname.
I've tested this method of getting the hostname for the socket connection is working in content script UIs and the background worker.
Code of Conduct