Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that #38 was not enough.
I kept getting the result (
{}
in that screenshot) rejected when usingplasmoStorage.get
:While using
chrome.storage.local.get
directly would work fine.https://developer.chrome.com/docs/extensions/reference/storage/#method-StorageArea-get documents the callback as
(items: object) => void
, no error is passed.https://github.com/sindresorhus/pify#errorfirst is false by default, and mentions: