small hydration improvements #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisgv
reviewed
Oct 16, 2023
src/hook.ts
Outdated
| @@ -92,6 +92,7 @@ export const useStorage = <T = any>(rawKey: RawKey, onInit?: Setter<T>) => { | |||
| return () => { | |||
| isMounted.current = false | |||
| storageRef.current.unwatch(watchConfig) | |||
| if (onInit instanceof Function) setRenderValue(onInit) | |||
There was a problem hiding this comment.
nit: let's put this under block inside curly brackets to keep it consistent with the repo
louisgv
approved these changes
Oct 16, 2023
|
Fixed formatting! Let me know if there's anything else. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the small changes discussed in #46.
If the
onInitparameter passed to the hook is a function, it is run to reset the render value when the storage unmounts. This allows the advanced use case of handling the loading/hydration state in theonInitfunction.I also renamed the boolean parameter to
isHydrated, which better describes the state it represents. This is purely a documentation change.