Organize FromBytes and ToBytes
#1073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchyCola
changed the title
FromBytes and ToBytes
MitchyCola
requested review from
klntsky,
jy14898,
amirmrad,
errfrom,
Luis-omega,
ngua and
pb99u069
jy14898
suggested changes
Oct 11, 2022
| foreign import _toBytes :: forall (a :: Type). a -> CborBytes | ||
|
|
||
| class ToBytes a where | ||
| toBytes' :: a -> CborBytes |
There was a problem hiding this comment.
This is not accurate for hash types. Emurgo/cardano-serialization-lib#263
Also, the original issue did not request a class here:
For toBytes, use Castable from untagged-union to remove the need to call asOneOf
What's the reason for the class? If we're keeping it, we need to make sure it's closed such that no other instances could be made, maybe with an instance chain and an error at the end of it.
There was a problem hiding this comment.
No need for the class. Castable would work better. Ping me if you find the Castable machinery confusing, I have a grasp of it.
rynoV
added a commit
that referenced
this pull request
Dec 2, 2022
rynoV
added a commit
that referenced
this pull request
Dec 2, 2022
rynoV
added a commit
that referenced
this pull request
Dec 2, 2022
3 tasks
|
Replaced by #1285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #560 .
Pre-review checklist
make format)## Unreleasedheader, using the appropriate sub-headings (### Added,### Removed,### Fixed), and the links to the appropriate issues/PRs have been included