make patch/minor/major - pass --no-commit to allow review and commit …

…with signoff (#244) * make patch/minor/major - pass --no-commit to allow review and commit with signoff Signed-off-by: Rob Ambalu <[email protected]>
Point72 · May 22, 2024 · 38c9534 · 38c9534
1 parent f11f5c6
commit 38c9534
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/Makefile b/Makefile
@@ -127,13 +127,13 @@ show-version:
 	@ bump2version --dry-run --allow-dirty pyproject.toml --list | grep current | awk -F= '{print $$2}'
 
 patch:
-	bump2version patch
+	bump2version patch --no-commit
 
 minor:
-	bump2version minor
+	bump2version minor --no-commit
 
 major:
-	bump2version major
+	bump2version major --no-commit
 
 ########
 # DIST #
@@ -205,7 +205,6 @@ dependencies-vcpkg:  ## install dependencies via vcpkg
 
 dependencies-win:  ## install dependencies via windows
 	choco install cmake curl winflexbison ninja unzip zip --no-progress -y
-
 
 ############################################################################################
 # Thanks to Francoise at marmelab.com for this

diff --git a/docs/wiki/dev-guides/Release-Process.md b/docs/wiki/dev-guides/Release-Process.md
@@ -108,7 +108,7 @@ development environment.
 
    Similarly, `make minor` and `make major` will update the version
    numbers for minor and major releases, respectively. Double-check
-   that the version numbers have been updated correctly with `git  diff`, and then `git commit` the change.
+   that the version numbers have been updated correctly with `git  diff`, and then `git commit -s` the change.
 
 1. Push your branch to GitHub, and trigger a "full" test run on the branch.