Enable -Werror for release gcc/clang builds

Signed-off-by: Adam Glustein <[email protected]>
Point72 · Jul 12, 2024 · 50727ea · 50727ea
1 parent 4eb82ae
commit 50727ea
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -194,6 +194,7 @@ else()
         -O3 \
         -g0 \
         -Wall \
+        -Werror \
         -Wno-deprecated-declarations \
         -Wno-deprecated \
         ")

diff --git a/cpp/csp/adapters/parquet/ParquetOutputAdapter.cpp b/cpp/csp/adapters/parquet/ParquetOutputAdapter.cpp
@@ -140,9 +140,10 @@ template< typename A, typename V = typename A::value_type >
 inline std::shared_ptr<::arrow::ArrayBuilder> makeArrayAndAttachToWriter( DialectGenericListWriterInterface::Ptr &listWriterInterface )
 {
     auto&& typedWriter = std::dynamic_pointer_cast<TypedDialectGenericListWriterInterface<V>>( listWriterInterface );
+    auto& listWriterInterfaceRef = *listWriterInterface;
     CSP_TRUE_OR_THROW( typedWriter != nullptr, TypeError,
                        "Expected " << typeid( TypedDialectGenericListWriterInterface<V> ).name() << " " << " got " <<
-                                   typeid( *listWriterInterface ).name() );
+                                   typeid( listWriterInterfaceRef ).name() );
 
     auto res = std::make_shared<A>();
     typedWriter -> setWriteFunction(

diff --git a/cpp/csp/python/PyStructToJson.cpp b/cpp/csp/python/PyStructToJson.cpp
@@ -72,7 +72,7 @@ inline rapidjson::Value toJson( const TimeDelta& val, const CspType& typ, rapidj
     // Convert TimeDelta to <sign><seconds>.<microseconds>
     // sign( 1 ) + seconds ( 18 ) + '.'( 1 ) + microseconds( 9 ) + '\0'( 1 )
     char buf[32] = {};
-    auto seconds = val.abs().asSeconds();
+    long seconds = val.abs().asSeconds();
     auto microseconds = static_cast<unsigned>( val.abs().nanoseconds() / NANOS_PER_MICROSECOND );
     auto len = sprintf( buf, "%c%ld.%06u", ( val.sign() >= 0 ) ? '+' : '-', seconds, microseconds );
     rapidjson::Value res;

diff --git a/cpp/csp/python/adapters/CMakeLists.txt b/cpp/csp/python/adapters/CMakeLists.txt
@@ -29,6 +29,10 @@ if(CSP_BUILD_PARQUET_ADAPTER)
         ${VENDORED_PYARROW_ROOT}/arrow/python/csv.cc
         ${VENDORED_PYARROW_ROOT}/arrow/python/filesystem.cc)
     add_library(parquetadapterimpl SHARED parquetadapterimpl.cpp ${ARROW_PYTHON_SRCS})
+    # Ignore warning regarding static datetime API initialization coming from vendored Arrow code
+    if(CMAKE_CXX_COMPILER_ID MATCHES "GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+        set_target_properties(parquetadapterimpl PROPERTIES COMPILE_OPTIONS "-Wno-unused-variable")
+    endif()
     target_link_libraries(parquetadapterimpl csp_core csp_engine cspimpl csp_parquet_adapter)
     target_include_directories(parquetadapterimpl PUBLIC ${ARROW_INCLUDE_DIR} ${PARQUET_INCLUDE_DIR} "${VENDORED_PYARROW_ROOT}")
     target_compile_definitions(parquetadapterimpl PUBLIC ARROW_PYTHON_STATIC)

diff --git a/cpp/tests/CMakeLists.txt b/cpp/tests/CMakeLists.txt
@@ -1,2 +1,12 @@
 add_subdirectory(core)
 add_subdirectory(engine)
+
+# Ignore bogus gcc warning which is coming from gtest headers
+# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105651
+set(SUBDIRS core engine)
+foreach(SUBDIR ${SUBDIRS})
+    get_directory_property(SUBDIR_TARGETS DIRECTORY ${SUBDIR} BUILDSYSTEM_TARGETS)
+    foreach(TARGET ${SUBDIR_TARGETS})
+        set_target_properties(${TARGET} PROPERTIES COMPILE_OPTIONS "-Wno-restrict")
+    endforeach()
+endforeach()