Move wiki docs into repo #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavithraes
commented
Feb 26, 2024
pavithraes
commented
Feb 26, 2024
pavithraes
commented
Feb 26, 2024
pavithraes
commented
Feb 26, 2024
melissawm
previously approved these changes
Feb 29, 2024
There was a problem hiding this comment.
This looks reasonable to me, and we can reevaluate in the future if a new action show up. For now I believe this does the job. Thanks @pavithraes !
timkpaine
force-pushed
the
pavithraes/move-docs-to-repo
branch
2 times, most recently
from
c820a30
to
fc931e4
Compare
|
Tested on my fork |
timkpaine
previously approved these changes
Mar 4, 2024
timkpaine
force-pushed
the
pavithraes/move-docs-to-repo
branch
from
5421c55
to
f5e359d
Compare
timkpaine
approved these changes
Mar 4, 2024
timkpaine
force-pushed
the
pavithraes/move-docs-to-repo
branch
from
f5e359d
to
63f46c7
Compare
Signed-off-by: Tim Paine <[email protected]>
Signed-off-by: Tim Paine <[email protected]>
Signed-off-by: Tim Paine <[email protected]>
Signed-off-by: Tim Paine <[email protected]>
Signed-off-by: Tim Paine <[email protected]>
Signed-off-by: Tim Paine <[email protected]>
timkpaine
force-pushed
the
pavithraes/move-docs-to-repo
branch
from
63f46c7
to
e7f12ad
Compare
timkpaine
approved these changes
Mar 4, 2024
|
@timkpaine Thanks for your updates here - it looks good to me. I've requested a review from After that, shall we merge crediting everyone from the initial commit here: 2acdade |
melissawm
approved these changes
Mar 4, 2024
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 |
There was a problem hiding this comment.
Is there a reason to use v1 instead of v4?
There was a problem hiding this comment.
it should probably be bumped, but dependabot will update it anyway
timkpaine
added
the
part: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112
Currently, we can't test the workflow until the PR is merged. However, I think we can temporarily enable runs on PRs to test it.Additional notes added inline.