-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move websocket backend to boost::beast #248
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrieg123
added
lang: c++
Issues and PRs related to the C++ codebase
adapter: websocket
Issues and PRs related to our websocket adapter
labels
May 22, 2024
wrieg123
requested review from
robambalu,
AdamGlustein,
svatasoiu,
alexddobkin,
ptomecek,
timkpaine and
czgdp1807
as code owners
May 22, 2024 21:37
wrieg123
force-pushed
the
wrr/update_ws_backend
branch
8 times, most recently
from
May 23, 2024 02:53
93bcf37
to
f5c25f4
Compare
timkpaine
previously requested changes
May 23, 2024
wrieg123
force-pushed
the
wrr/update_ws_backend
branch
3 times, most recently
from
May 23, 2024 11:06
dbd5475
to
23ab78f
Compare
robambalu
requested changes
May 23, 2024
wrieg123
force-pushed
the
wrr/update_ws_backend
branch
from
May 23, 2024 18:12
23ab78f
to
4f6a839
Compare
robambalu
reviewed
May 23, 2024
wrieg123
force-pushed
the
wrr/update_ws_backend
branch
2 times, most recently
from
May 23, 2024 20:50
29ef21d
to
04c2bcb
Compare
robambalu
reviewed
May 23, 2024
robambalu
reviewed
May 23, 2024
wrieg123
force-pushed
the
wrr/update_ws_backend
branch
from
May 23, 2024 22:21
04c2bcb
to
a850d7b
Compare
wrieg123
force-pushed
the
wrr/update_ws_backend
branch
from
May 24, 2024 01:49
a850d7b
to
0a66de7
Compare
Signed-off-by: Will Rieger <[email protected]>
wrieg123
force-pushed
the
wrr/update_ws_backend
branch
from
May 24, 2024 12:28
0a66de7
to
89b20bb
Compare
robambalu
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
adapter: websocket
Issues and PRs related to our websocket adapter
lang: c++
Issues and PRs related to the C++ codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the websocket backend off of websocketpp to boost::beast which looks like it should support both windows and c++20.
Fixes #253
Fixes #236