Add tests for example scripts #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Goldbaum <[email protected]>
Signed-off-by: Nathan Goldbaum <[email protected]>
Signed-off-by: Nathan Goldbaum <[email protected]>
Signed-off-by: Nathan Goldbaum <[email protected]>
ngoldbaum
force-pushed
the
njg/test-examples
branch
from
190b4af
to
5631c7e
Compare
|
closing in favor of #26 |
|
I'm going to rewrite this to drop the new tests and modifications to the examples, but there are two other fixes in here that should be merged IMO. By the way, maybe we should be assigning issues to ourselves if we're working on them to avoid accidentally duplicating work like this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11.
In addition to the new tests, this adds a few dependencies needed by examples to to
pyproject.tomlanddev-environment.ymland fixes a couple incorrect package names indev-environment.yml.It also fixes the
csp.statsusage ine_21_numpy_stats.py, which assumescsp.statsis usable without explicitly importing it first. Happy to revert the change tocsp/__init__.pyand add an import to that example if not importingstatsinto thecspmodule was done on purpose.I also decreased the runtime of a number of the tests (one of them never completed) to make the new test I'm adding complete in a reasonable time. Happy to adjust the timeouts that I changed here.
A couple of the examples have bugs, I opened #23 and #24 to track those and marked those examples as xfail.