Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tag info a more prominent note #266

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Make tag info a more prominent note #266

merged 1 commit into from
Jun 5, 2024

Conversation

timkpaine
Copy link
Member

slight tweak on #249 which I didn't notice, this makes it a more prominent note:

Screenshot 2024-06-04 at 18 18 54

vs

Screenshot 2024-06-04 at 18 19 04

@timkpaine timkpaine added part: documentation Improvements/bugs/changes to documentation tag: internal Issues and PRs for maintainance of the project - not interesting to external users labels Jun 4, 2024
@timkpaine timkpaine requested a review from ngoldbaum June 4, 2024 22:19
ngoldbaum
ngoldbaum approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should render more nicely with this

@timkpaine timkpaine merged commit 905e869 into main Jun 5, 2024
1 check passed
@timkpaine timkpaine deleted the tkp/moreprominentnote branch June 5, 2024 13:03
@timkpaine
Copy link
Member Author

image

yep looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngoldbaum ngoldbaum ngoldbaum approved these changes

@robambalu robambalu Awaiting requested review from robambalu robambalu is a code owner

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

Assignees
No one assigned
Labels
part: documentation Improvements/bugs/changes to documentation tag: internal Issues and PRs for maintainance of the project - not interesting to external users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @ngoldbaum