Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in DialectGenericType in to_json #269

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fix memory leak in DialectGenericType in to_json #269

merged 1 commit into from
Jun 6, 2024

Conversation

arhamchopra
Copy link
Collaborator

This PR fixes a memory leak in the to_json method for structs.

@arhamchopra arhamchopra marked this pull request as ready for review June 6, 2024 13:21
@arhamchopra arhamchopra merged commit d82f88b into main Jun 6, 2024
29 checks passed
@arhamchopra arhamchopra deleted the ac/fix_memory_leak_to_json branch June 6, 2024 13:25
@timkpaine timkpaine added the type: bug Concrete, reproducible bugs label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamGlustein AdamGlustein AdamGlustein approved these changes

@robambalu robambalu Awaiting requested review from robambalu robambalu is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

Assignees
No one assigned
Labels
type: bug Concrete, reproducible bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arhamchopra @AdamGlustein @timkpaine