Deprecate defineStruct and defineNestedStruct in favor of define_struct and define_nested_struct #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomecek
requested review from
robambalu,
AdamGlustein,
svatasoiu,
alexddobkin,
timkpaine and
czgdp1807
as code owners
robambalu
previously approved these changes
Jul 12, 2024
timkpaine
requested changes
Jul 12, 2024
…ct and define_nested_struct. Signed-off-by: Pascal Tomecek <[email protected]>
ptomecek
force-pushed
the
pit/define_struct
branch
from
6cc346e
to
71fbf26
Compare
timkpaine
approved these changes
Jul 12, 2024
timkpaine
added
the
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PEP8 compliance. The old functions still exist (added a new unit test), but are tagged as deprecated using the
deprecatedmodule.