Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signature to adapters so that help works as expected #334

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add signature to adapters so that help works as expected #334

merged 1 commit into from
Jul 22, 2024

Conversation

ptomecek
Copy link
Collaborator

@ptomecek ptomecek commented Jul 15, 2024 •
edited by timkpaine
Loading

ref: #307

@timkpaine timkpaine changed the title Add signature to adapters so that help works as expected, part of #307 Add signature to adapters so that help works as expected Jul 15, 2024
@timkpaine timkpaine added the type: enhancement Issues and PRs related to improvements to existing features label Jul 15, 2024
@ptomecek ptomecek linked an issue Jul 15, 2024 that may be closed by this pull request
csp.add_graph_output wrong signature suggestion by editor #307
Closed
@timkpaine timkpaine force-pushed the pit/adapter_signature branch 2 times, most recently from 7c01d7b to c8fd883 Compare July 16, 2024 19:03
@ptomecek ptomecek merged commit 4681d7b into main Jul 22, 2024
29 checks passed
@ptomecek ptomecek deleted the pit/adapter_signature branch July 22, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robambalu robambalu robambalu approved these changes

@timkpaine timkpaine timkpaine approved these changes

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

Assignees
No one assigned
Labels
type: enhancement Issues and PRs related to improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

csp.add_graph_output wrong signature suggestion by editor
3 participants
@ptomecek @timkpaine @robambalu