Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency for python 3.8, reenable sdist #53

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Feb 8, 2024

This PR does three things:

"Full" build: https://github.com/Point72/csp/actions/runs/7855760939

@timkpaine timkpaine added part: github_actions PRs that update GitHub Actions code tag: internal Issues and PRs for maintainance of the project - not interesting to external users part: build Issues and PRs related to the build process labels Feb 8, 2024
@timkpaine timkpaine force-pushed the tkp/disttest branch 4 times, most recently from 1f96704 to de475d0 Compare February 8, 2024 19:36
@timkpaine timkpaine marked this pull request as ready for review February 8, 2024 22:39
@timkpaine
Copy link
Member Author

I'm going to make ldclassic a cmake flag since it looks like the cmake function to detect it doesn't work, then I'm going to try another full build with Mac enabled and then we can merge.

@timkpaine timkpaine marked this pull request as draft February 10, 2024 03:35
Skip profiler test segment that relies on graphviz
auto-use ld_classic outside broken cmake detection

Signed-off-by: Tim Paine <[email protected]>
@timkpaine timkpaine marked this pull request as ready for review February 10, 2024 15:18
Copy link
Contributor

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I got a request from @robambalu to add Python3.8 wheels to the build so I'm going to do add that in a followup. Let me know if that steps on anything you were planning.

@ngoldbaum
Copy link
Contributor

I'm seeing this when I try to merge, which I think is incorrect?

image

Closing and re-opening to check if that will let me merge this on github, otherwise I'll merge it manually.

@ngoldbaum ngoldbaum closed this Feb 12, 2024
@ngoldbaum ngoldbaum reopened this Feb 12, 2024
@ngoldbaum
Copy link
Contributor

Maybe someone turned on branch protection and required signed commits sometime in the last few days?

@ngoldbaum
Copy link
Contributor

I guess so:

git push upstream main
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: Commits must have verified signatures. Required status check "test (ubuntu-22.04, 3.11, false)" is expected.
To github.com:Point72/csp.git
 ! [remote rejected] main -> main (protected branch hook declined)
error: failed to push some refs to 'github.com:Point72/csp.git'

@timkpaine timkpaine merged commit 17f20db into main Feb 13, 2024
43 checks passed
@timkpaine timkpaine deleted the tkp/disttest branch February 13, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: build Issues and PRs related to the build process part: github_actions PRs that update GitHub Actions code tag: internal Issues and PRs for maintainance of the project - not interesting to external users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants