-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency for python 3.8, reenable sdist #53
Conversation
1f96704
to
de475d0
Compare
I'm going to make ldclassic a cmake flag since it looks like the cmake function to detect it doesn't work, then I'm going to try another full build with Mac enabled and then we can merge. |
Skip profiler test segment that relies on graphviz auto-use ld_classic outside broken cmake detection Signed-off-by: Tim Paine <[email protected]>
1637508
to
c10666a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I got a request from @robambalu to add Python3.8 wheels to the build so I'm going to do add that in a followup. Let me know if that steps on anything you were planning.
Maybe someone turned on branch protection and required signed commits sometime in the last few days? |
I guess so:
|
This PR does three things:
"Full" build: https://github.com/Point72/csp/actions/runs/7855760939