-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a workflow job to automate uploading to testpypi #54
Conversation
7bbd97c
to
67f519b
Compare
|
The other issue is that right now the version is static so testpypi won't let us upload a new release with every merged PR. I think |
67f519b
to
0d45535
Compare
For now just set it to only upload if a tag is added. |
0d45535
to
f0775ac
Compare
Can you make a tag like |
a96125f
to
9bf0c5a
Compare
Thanks for the suggestion to try on my fork. The way I originally configured it there were some bugs. Also I got tripped up on the check for tags that start with Here's the action run https://github.com/ngoldbaum/csp/actions/runs/7879281136/job/21501011776 It failed to upload because my fork isn't a trusted publisher to testpypi for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me so I will go ahead and approve @ngoldbaum.
That way we can test the release and iterate as needed
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
It's not clear to me why github is saying I'm dismissing stale reviews, it seems to be happening automatically. |
Signed-off-by: Nathan Goldbaum <[email protected]>
9bf0c5a
to
a0e839d
Compare
I rebased again, I think if one of you approve it will be mergeable. |
Not sure how to make ASCII art matching the other jobs