Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symphony adapter #87

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Symphony adapter #87

merged 1 commit into from
Feb 22, 2024

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Feb 14, 2024

Fixes #86

Needs:

@timkpaine timkpaine added type: feature Issues and PRs related to new features adapter: new Issues and PRs related to creating new input/output adapters tag: wip PRs that are a work in progress - converted to drafts labels Feb 14, 2024
@timkpaine timkpaine removed the tag: wip PRs that are a work in progress - converted to drafts label Feb 20, 2024
@timkpaine timkpaine changed the title [WIP] symphony adapter Symphony adapter Feb 20, 2024
@timkpaine timkpaine marked this pull request as ready for review February 20, 2024 00:54
stephenmarkacs
stephenmarkacs previously approved these changes Feb 20, 2024
Copy link
Collaborator

@stephenmarkacs stephenmarkacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I grabbed out the text of symphony.py and compared it vs original and indeed the difference is just how the secrets are handled (here passed in) and formatting.

Signed-off-by: Tim Paine <[email protected]>
@timkpaine timkpaine merged commit a4da40b into main Feb 22, 2024
14 checks passed
@timkpaine timkpaine deleted the tkp/symphony branch February 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter: new Issues and PRs related to creating new input/output adapters type: feature Issues and PRs related to new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open source our Symphony adapter
2 participants