Fixed missing virtual function #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem on my side, happy you found that useful! |
|
I'm not even sure what is the status of this repository and how it is used. I guess @jspricke is the one who has to decide and merge. |
|
Which OpenNI version produces this error? Maybe you want the https://github.com/PointCloudLibrary/Sensor/tree/unstable branch? |
|
I have OpenNI installed from Fedora 25 repositories, version 1.5.7.10-8.fc25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ph4m, I've adjusted your origianl PR (avin2#5) for this repository, with all credits to you. Let me know if this is a problem.
PointCloud Library maintainers, this PR fixes the following error, when running
Platform/Linux/CreateRedist/RedistMaker:In file included from /usr/include/ni/XnTypes.h:28:0, from /usr/include/ni/XnModuleInterface.h:27, from /usr/include/ni/XnModuleCppInterface.h:33, from ../../../../Source/XnDeviceSensorV2/XnSensorProductionNode.h:28, from ../../../../Source/XnDeviceSensorV2/XnSensorGenerator.h:28, from ../../../../Source/XnDeviceSensorV2/XnSensorMapGenerator.h:28, from ../../../../Source/XnDeviceSensorV2/XnSensorDepthGenerator.h:28, from ../../../../Source/XnDeviceSensorV2/XnSensorDepthGenerator.cpp:25: ../../../../Source/XnDeviceSensorV2/XnSensorDepthGenerator.cpp: In member function ‘virtual XnSensorGenerator* XnExportedSensorDepthGenerator::CreateGenerator(xn::Context&, xn::Device&, XnDeviceBase*, const XnChar*)’: /usr/include/ni/XnOS.h:331:49: error: invalid new-expression of abstract class type ‘XnSensorDepthGenerator’ #define XN_NEW(type, ...) new type(__VA_ARGS__) ^