Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix in toPCLPointCloud2 if input cloud has no points #1723

Merged
merged 1 commit into from
Oct 24, 2016
Merged

fix in toPCLPointCloud2 if input cloud has no points #1723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion common/include/pcl/conversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,10 @@ namespace pcl
// Fill point cloud binary data (padding and all)
size_t data_size = sizeof (PointT) * cloud.points.size ();
msg.data.resize (data_size);
memcpy (&msg.data[0], &cloud.points[0], data_size);
if (data_size)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd write data_size > 0 to be clear what's happening although it's equivalent since it's of type size_t.

{
memcpy(&msg.data[0], &cloud.points[0], data_size);
}

// Fill fields metadata
msg.fields.clear ();
Expand Down