Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VoxelGrid : Possibility to specify a minimum number of points per voxel #434

Merged
merged 1 commit into from
Feb 11, 2014
Merged

VoxelGrid : Possibility to specify a minimum number of points per voxel #434

merged 1 commit into from
Feb 11, 2014

Conversation

rbregier
Copy link
Contributor

@rbregier rbregier commented Jan 6, 2014

Hi,

I modified the VoxelGrid filter in order to be able to filter voxels which contains less than a given number of points (specified via setMinimumPointsNumberPerVoxel - set equal to 0 which leads to the same behaviour as previously).

Romain

@jspricke
Copy link
Member

Hi Roman, thanks for your contribution. There seem to be some whitespace errors in there, can you reformat the patch according to our style guide: http://pointclouds.org/documentation/advanced/pcl_style_guide.php#pcl-style-guide. Also, would be great if you could add a unit test as well. Thanks!

@rbregier
Copy link
Contributor Author

Hi,
I am quite busy for now, but sure I will try to have a look at it next month.

@rbregier
Copy link
Contributor Author

rbregier commented Feb 1, 2014

Hi Jochen,
I fixed whitespaces but I have not added a test, could you add one yourself please?
I encounter various errors when I try to build PCL tests (I work on Win 7 64bits, VS2010, I installed GTest but there are linker errors in the bearing_angles test among others) and I won't have time to investigate those.
Thanks.

jspricke
jspricke reviewed Feb 1, 2014
View reviewed changes
filters/include/pcl/filters/impl/voxel_grid.hpp
// and of the first point not belonging to.
std::vector<std::pair<unsigned int, unsigned int> > first_and_last_indices_vector;
// Worst case size
first_and_last_indices_vector.reserve(index_vector.size());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a space before the bracket.

@jspricke
Copy link
Member

jspricke commented Feb 1, 2014

Hi Roman,

I've added some style comments, would be great if you could fix them. Regarding the Windows build, can you fill a bug report, so we can investigate?

Thanks!

Jochen

@rbregier
Copy link
Contributor Author

rbregier commented Feb 5, 2014

Hi Jochen,
Style should be ok this time. Visual Studio does not represent tabs whith the same numbers of spaces as git by default, I will know it for the next time.
Regarding tests, all right I am going to open a new issue as soon as possible.

jspricke added a commit that referenced this pull request Feb 11, 2014
@jspricke
Merge pull request #434 from rbregier/master
7156594 
VoxelGrid : Possibility to specify a minimum number of points per voxel
@jspricke jspricke merged commit 7156594 into PointCloudLibrary:master Feb 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbregier @jspricke