-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new CentroidPoint
class
#586
Add a new CentroidPoint
class
#586
Conversation
This looks very nice! Just one nitpicky little thing: By the way, kudos, using The unit tests look good too. |
There are quite a number of functions dealing with centroid, mean, and covariance computation. They all are grouped in 'common/centroid.h' header. Therefore it makes sense to group their corresponding test functions in a separate file. Hence creation of 'test_centroid.cpp'.
Good point! Let's use faster code anyways.
I am not 100% sure, but I think there is no run-time |
Add a new `CentroidPoint` class
Fixes PointCloudLibrary#1413, based on PointCloudLibrary#1170, modified to make use of PointCloudLibrary#586.
Addresses PointCloudLibrary#1413 , based on PointCloudLibrary#1170, modified to make use of PointCloudLibrary#586. Includes extra tests for RGBA and for testing downsamplealldata=false
Addresses PointCloudLibrary#1413 , based on PointCloudLibrary#1170, modified to make use of PointCloudLibrary#586. Includes extra tests for RGBA and for testing downsamplealldata=false
Addresses PointCloudLibrary#1413 , based on PointCloudLibrary#1170, modified to make use of PointCloudLibrary#586. Includes extra tests for RGBA and for testing downsamplealldata=false
Originally a part of #473, this turned out to be a self-contained feature which might be useful not only inside
octree
module.The class is accompanied by a couple of
computeCentroid()
functions (designed upon the existingcompute3DCentroid()
andcomputeNDCentroid()
), plus a bunch of unit tests.