Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added legends arceus pokeballs #1118

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Added legends arceus pokeballs #1118

merged 3 commits into from
Aug 8, 2024

Conversation

lati111
Copy link
Contributor

@lati111 lati111 commented Aug 5, 2024

  • Created item category hisuian-balls for the legends arceus pokeballs
  • Added all the hisuian pokeball versions. Used identifier naming scheme from PKHeX (la prefix for identifiers) since no naming scheme exists for them currently
  • Added flavor text for hisuian pokeball versions copied from bulbapedia
  • Hisuian pokeball sprites token from pokesprite as usual (I believe these were added correctly, but I haven't added sprites before so I may have made a mistake)

@lati111
Copy link
Contributor Author

lati111 commented Aug 5, 2024

Definitely mucked something up here, probably something with the sprites. Guess I'll have to do some more research on how it actually works instead of just trying a quick addition I was hoping it would be

@phalt
Copy link
Member

phalt commented Aug 6, 2024

@lati111 Take your time - its a big and complicated project now 😄 you got this!

@lati111
Copy link
Contributor Author

lati111 commented Aug 6, 2024

@lati111 Take your time - its a big and complicated project now 😄 you got this!

Indeed. It doesn't help that I can't find much internal documentation on the hows haha

@Naramsim
Copy link
Member

Naramsim commented Aug 6, 2024

Hi, I'm not sure we need to add a whole new category to the data.

Isn't it best to add just the new item and use the same category as the standard pokeball?

items.csv

4,poke-ball,34,200,,
...
2219,poke-ball-hisui,34,200,,...

Something like the above?

@lati111
Copy link
Contributor Author

lati111 commented Aug 6, 2024

Hi, I'm not sure we need to add a whole new category to the data.

Isn't it best to add just the new item and use the same category as the standard pokeball?

items.csv

4,poke-ball,34,200,,
...
2219,poke-ball-hisui,34,200,,...

Something like the above?

That definitely works as well. I assumed a new category would be requires as there are seperate categories for standard, special and apricorn balls already. I can definitely move it into that though.

@Naramsim
Copy link
Member

Naramsim commented Aug 6, 2024

Let's go with that. To me, these Pokeballs are basically the same as standard ones or special ones. They are restricted only to Pokemon Legends Arceus according to Bulbapedia.

@Naramsim Naramsim merged commit 77a06ec into PokeAPI:master Aug 8, 2024
4 checks passed
@Naramsim
Copy link
Member

Naramsim commented Aug 8, 2024

Thanks @lati111

@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants