-
-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DLC2 learnsets #999
Add DLC2 learnsets #999
Conversation
This is a big PR, I'd wait some days for a review. Otherwise I'll merge |
Thank you! I’ll check this in this weekend. |
@penelopeysm Thank you again for this great contribution 😄 I checked your data in my tool. I found some issues.
They seem to be reflecting only moves learned by new TMs. Could you check them again? Additionally, I checked some situations:
As I checked, no more issues were found. Thank you. |
Ah, I missed those. That should be fixed now! Thank you for checking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the data, it seems to be correct 💯
Thank you very much again!
Thanks so much @penelopeysm !!! And @giginet thanks for the review! |
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
Hello! This PR adds in learnsets for Indigo Disk, including old mons which can now learn new TMs. @giginet, I'm very sorry it's taken me longer than I had anticipated to get round to this! I had a lot of real life stuff to take care of.
As before, I have not exhaustively verified the data, I've just checked a few entries by hand. Let me know if anything needs updating :)
Closes #987