-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix: Strange Location] Pins the pgoapi pip to v1.1.0 tag to fix f2i/i2f bug #1058
Conversation
|
@jovobe I see that |
@douglascamata No, I just started the bot and it seems to work properly. |
@douglascamata This should fix #1046, #1045 and #1039. |
I removed all references to i2f and made a patch, bot works for now. |
@LasseSkogland did you update dev version ? |
EDIT: I did not commit anything to the repository, i only created a patch file. Yes, but couple seconds after i created the patch a new commit came in, somewhat invalidating the patch file.. |
@LasseSkogland Could you make a PR removing the i2f method from the code? |
now dev version is working on me |
Yes dev version works, but it is a lazy fix. I will create a pull request and properly fix this issue. |
Thanks Lasse, it's appreciated. |
@LeaklessGfy yes not stable :( |
Short Description:
Due to an update in the pgoapi the f2i and i2f functions are not needed anymore. To fix this in the current code the fastest solution is to pin the pgoapi pip ti the v1.1.0 tag.
After this PR the users have to
pip install -r requirements.txt
again.Fixes: