Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix: Strange Location] Pins the pgoapi pip to v1.1.0 tag to fix f2i/i2f bug #1058

Merged
merged 1 commit into from
Jul 26, 2016

Conversation

jovobe
Copy link
Contributor

@jovobe jovobe commented Jul 26, 2016

Short Description:
Due to an update in the pgoapi the f2i and i2f functions are not needed anymore. To fix this in the current code the fastest solution is to pin the pgoapi pip ti the v1.1.0 tag.
After this PR the users have to pip install -r requirements.txt again.

Fixes:

  • Strange locations due to update in the pgoapi

@douglascamata
Copy link
Member

pgoapi should have been pinned to an specific commit (I coded this pin), but someone removed the check. Did you test if tag 1.1.0 does work for us in every way we use the api?

@douglascamata
Copy link
Member

@jovobe I see that pgoapi got an updated version go the protobuf structures and changed code a bit in the last few hours. So i'm urgently merging this. Thanks!

@jovobe
Copy link
Contributor Author

jovobe commented Jul 26, 2016

@douglascamata No, I just started the bot and it seems to work properly.

@douglascamata douglascamata merged commit ac29a09 into PokemonGoF:dev Jul 26, 2016
@jovobe
Copy link
Contributor Author

jovobe commented Jul 26, 2016

@douglascamata This should fix #1046, #1045 and #1039.

@LasseSkogland
Copy link

I removed all references to i2f and made a patch, bot works for now.
https://gist.github.com/LasseSkogland/f4c9fb3459d1ef5f4a2a6b842d6c4594

@ZgrK
Copy link
Contributor

ZgrK commented Jul 26, 2016

@LasseSkogland did you update dev version ?

@LasseSkogland
Copy link

LasseSkogland commented Jul 26, 2016

EDIT: I did not commit anything to the repository, i only created a patch file.

Yes, but couple seconds after i created the patch a new commit came in, somewhat invalidating the patch file..

@glennvgastel
Copy link
Contributor

@LasseSkogland Could you make a PR removing the i2f method from the code?

@ZgrK
Copy link
Contributor

ZgrK commented Jul 26, 2016

now dev version is working on me

@LasseSkogland
Copy link

Yes dev version works, but it is a lazy fix. I will create a pull request and properly fix this issue.

@glennvgastel
Copy link
Contributor

Thanks Lasse, it's appreciated.

@ZgrK
Copy link
Contributor

ZgrK commented Jul 26, 2016

@LeaklessGfy yes not stable :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants