PokemonGo-Bot/issues#3366: use self.logger.warning instead of log.logger #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -176,7 +176,7 @@ def update_map_location(self): | |||
| except ValueError: | |||
| err = 'Map location data was not valid' | |||
| self._emit_failure(err) | |||
| return log.logger(err, 'red') | |||
There was a problem hiding this comment.
log.logger isn't even a thing...
|
log.logger is removed? |
|
@maestroi are you thinking of |
|
feedback on this anyone? @douglascamata |
|
It should use the new event system and send as little events as possible. |
|
@sandbochs How do you want to proceed? |
|
Outdate, need close. Thanks for PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
MoveToMap Task is using the incorrect function to log warnings. I've updated to use
self.logger.warningincluded inBaseTask.Fixes (provide links to github issues if you can):
Closes #3366